xunit / devices.xunit

xUnit.net Runners for Devices
Other
73 stars 36 forks source link

Filtered tests never have status updated on Android #22

Closed kentcb closed 7 years ago

kentcb commented 9 years ago

When running a test under Android when a filter has been entered, the status for the test is never updated. It just kind of hangs indefinitely. Running the same test without a filter (or on iOS with or without a filter) works as expected.

A repro solution can be downloaded from here.

Here's an example showing the repro with a filter entered and the test consequently stuck:

nexus 5 lollipop screenshot 1

clairernovotny commented 9 years ago

I just tried this in VS using the VS Android emulator and could not repro. I'm using a 5.1.1 android image.

repro

kentcb commented 9 years ago

This fails for me on both device and emulator (Nexus 5 lollipop).

I'm using XS stable channel. Are you on stable?

clairernovotny commented 9 years ago

I'm on stable, but I don't use XS. I'm using VS 2015 with the latest Xamarin tools...

kentcb commented 9 years ago

Actually, the problem is more subtle than I first realized. Here is what I can do to repro:

At this point, the test cell turns orange and stays that way indefinitely. However, I've just found that I can then tap away from the cell back to the filter entry. It then updates its status but remains orange.

clairernovotny commented 9 years ago

Could this be a Xamarin Forms bug? There's really little that xUnit is doing other than running a test on tap of a test and/or the run filtered/all buttons. Everything else is Xam Forms databinding?

kentcb commented 9 years ago

Feels like it could be anything in the stack at this point :(

Thing is, it works in iOS. So perhaps it does have something to do with the droid platform implementation. But then why does it work for you via VS?

I'm currently updating my VS install to try it there (though it's on alpha).

kentcb commented 9 years ago

Ugh, after all those downloads and updates, I'm just getting deployment errors on my VS box. I give up.

This is not as big a deal as I originally thought because it is a UI quirk rather than a hang. I might get time to look into this further later on, but right now I need to move onto other things.

Thanks @onovotny

clairernovotny commented 9 years ago

I'll leave this issue open for awhile; if you get time to locate root cause, I'd be happy to look deeper.

clairernovotny commented 8 years ago

Has this still happened or can I close this issue?

kentcb commented 8 years ago

Sorry, meant to reply to this earlier but forgot. Yes, it's still an issue. tbh, I don't run tests in the devices runner often anymore, so this doesn't crop up as much. And when it does, I know exactly why the UI isn't updating and just tap around a bit so it does. But it would still be good to fix this at some point.

clairernovotny commented 8 years ago

I would like to fix this...but still not sure how to repro?

clairernovotny commented 7 years ago

Is this still an issue? Maybe a later Xam Forms fixed something? Can you please try 2.2-rc1 and let me know?

kentcb commented 7 years ago

Just tried this. It is indeed working now in 2.2-rc1 🎉 No doubt one of many XF bugs fixed since 2.0.1.