Make Xamarin Forms based test runner more friendly for UI Tests

xunit / devices.xunit

xUnit.net Runners for Devices

Other

73 stars 36 forks source link

Make Xamarin Forms based test runner more friendly for UI Tests #51

Closed Bowman74 closed 7 years ago

Bowman74 commented 7 years ago

This PR does two things:

Adds unique AutomationIds to the main page for each individual test run and the Run All button. Since Xamarin Forms does not handle automation Ids on TextCells (or any cells) a custom renderer needed to be added. The AutomationIds are currently only setup for Android and iOS use.
Adds a "Completed -" prefix message to the test run output. This can be watched for by UI Tests so they can wait until all the test actually are complete.

dnfclas commented 7 years ago

Hi @Bowman74, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

dnfclas commented 7 years ago

@Bowman74, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

clairernovotny commented 7 years ago

thanks!

clairernovotny commented 7 years ago

@Bowman74 I am about to push out 2.2-rc1 that has these changes in it. Any chance you'd have a few min to "pretty up" the new diagnostic message panel at the bottom of the home screen? I'd appreciate it! :)

Bowman74 commented 7 years ago

I'll take a look.

Bowman74 commented 7 years ago

@onovotny ,

Looks like DeviceRunner.cs doesn't compile for me due to some recent changes. Looks like a method nested in another method. Problem is on line 224:

Task RunTests(Func<IReadOnlyList<AssemblyRunInfo>> testCaseAccessor)
{
    var tcs = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);

    void Handler()
    {

...

clairernovotny commented 7 years ago

Oh... you need VS 2017 for that, it's a local method....

Bowman74 commented 7 years ago

Ah, I'll switch over to my Windows VM then.