search

xunit / visualstudio.xunit

VSTest runner for xUnit.net (for Visual Studio Test Explorer and dotnet test)
https://xunit.net/
Other
144 stars 81 forks source link

Fix test discovery for FullyQualifiedName and DisplayName #380

Closed ZCao-96 closed 1 year ago

ZCao-96 commented 1 year ago

This PR is to fix test discovery for FullyQualifiedName and DisplayName filter. As in #370 , issue details has been brought out and these are code changes that I propose.

Here is the screenshot showing that it works. Ignoring the log that starts with [xUnit , it will only print the full name, which is Class plus method, on the screen. image UT for the method that I made changes is written as well.

@bradwilson @nohwnd Would you please review it and feel free to comment if there is anything needed to fix? Thanks!

ZCao-96 commented 1 year ago

@dotnet-policy-service agree

bradwilson commented 1 year ago

Thanks, this looks pretty good. I especially appreciate all the tests. 😄

I think I want to make an optimization or two and maybe a bit of stylistic change. I'll just push my changes into your branch and then merge it.

bradwilson commented 1 year ago

Thanks!