@GFLAGS_IS_A_DLL@ expands to empty string in gflags_declare.h

xunzhang / gflags

Automatically exported from code.google.com/p/gflags

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

@GFLAGS_IS_A_DLL@ expands to empty string in gflags_declare.h #77

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Build on Linux with BUILD_SHARED_LIBS and BUILD_STATIC_LIBS enabled.
2. Notice that line #45 of include/gflags/gflags_declare.h is:
    #  if  && defined(_MSC_VER)

What is the expected output? What do you see instead?

The expected output is:

    #  if 0 && defined(_MSC_VER)

What version of the product are you using? On what operating system?

This is the master branch from Github.

Original issue reported on code.google.com by godbyk@gmail.com on 25 Mar 2014 at 3:53

GoogleCodeExporter commented 9 years ago

Thanks for reporting. This mistake fall through the cracks as the header file 
is configured prior to settings GFLAGS_IS_A_DLL in the CMakeLists.txt. Also, if 
both libraries are being build, we will need to make a default choice for this 
on Windows. The exported CMake targets can have a property that specified which 
GFLAGS_DLL_DECL to use in this case.

To fix this issue, I modified the build configuration to always set 
GFLAGS_IS_A_DLL to 1 if BUILD_SHARED_LIBS is ON. You can of course always 
define GFLAGS_DLL_DECL yourself before including the header file, but as Unix 
user you should of course not have to.

Original comment by andreas....@gmail.com on 25 Mar 2014 at 3:28

Changed state: Accepted
Added labels: Milestone-v2.1.1

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 09f7800768f8.

Original comment by andreas....@gmail.com on 25 Mar 2014 at 3:30

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 6040eac5b357.

Original comment by andreas....@gmail.com on 25 Mar 2014 at 3:30

GoogleCodeExporter commented 9 years ago

Opened issue 78 for addressing the import definition of GFLAGS_DLL_DECL to help 
users/CMake set it properly if both shared and static libraries were 
build/installed.

Original comment by andreas....@gmail.com on 25 Mar 2014 at 3:39

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 38c4402f58ad.

Original comment by andreas....@gmail.com on 27 Mar 2014 at 1:31

GoogleCodeExporter commented 9 years ago

Issue 81 has been merged into this issue.

Original comment by andreas....@gmail.com on 30 Mar 2014 at 1:43