search

xupeng1206 / ReaChord

9 stars 3 forks source link

Main #4

Closed GoranKovac closed 11 months ago

GoranKovac commented 11 months ago

Commit 1. Fixes crash when window size is too small. After the crash since Imgui stores values you are unable to open the script anymore. Commit 2. Optional Constrain window to fixed minimal size

Commit 3. Added initial Circle of fifts implementation:

1.Added Checkbox at top right to toggle it

  1. Expand/shrink size of the window for current resize logic to work

It would be nice to constrain window size with this. Prepared the code for that but its commented out (my comments start with "--!" since I'm using better comments extenstion.

There are hard-coded stuff such as scales, chord progression text etc. This should ideally be read by current scale data but this is out of my league here since I don't understand how it works.

Also chords can be played when clicking on it but again this needs to be fixed and improved.

xupeng1206 commented 11 months ago

Cool, and how about make pr small, small pr is easy to merge, thanks

GoranKovac commented 11 months ago

Sorry that was my bad... my intention was do small pr but as I've commited more additions i saw they are all in that one so I edited the post.Sent from my Galaxy -------- Original message --------From: xupeng1206 @.> Date: 11/22/23 16:11 (GMT+01:00) To: xupeng1206/ReaChord @.> Cc: GoranKovac @.>, Author @.> Subject: Re: [xupeng1206/ReaChord] Main (PR #4) Cool, and how about make pr small, small pr is easy to merge, thanks

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>