xuranw / MuSiC

Multi-subject Single Cell Deconvolution
https://github.com/xuranw/MuSiC
GNU General Public License v3.0
220 stars 83 forks source link

Music2 bug in "music2_prop_t_statistics" function #121

Open ste-depo opened 11 months ago

ste-depo commented 11 months ago

Error:

Error in (function (classes, fdef, mtable)  : 
  unable to find an inherited method for function ‘exprs’ for signature ‘"matrix"’

Raised from: https://github.com/xuranw/MuSiC/blame/0a3e3af45d4bd018939013660a3e83e580fa3bac/R/music2.R#L340

The actual code tries to extract expression from "bulk.case" pretending it is an object of ExpressionSet class, while it's already a matrix.

Removing exprs() fixes the bug

marounbs commented 10 months ago

Yes. Reached the same conclusion, and lost a couple of hours. Too bad I didn't see your post first.

alexandriatran commented 2 months ago

Thanks for documenting. I just ran into this issue using MuSiC installed from tutorial instructions, so it has not yet been resolved on that branch.