xuri / excelize-wasm

A WebAssembly build of the Go Excelize library for reading and writing Microsoft Excel™ (XLAM / XLSM / XLSX / XLTM / XLTX) spreadsheets
https://xuri.me/excelize
BSD 3-Clause "New" or "Revised" License
197 stars 34 forks source link

New function GetMergeCells has been added #28

Closed LogikMeister closed 3 months ago

LogikMeister commented 3 months ago

PR Details

Description

GetMergeCells provides a function to get merged cells from a specific worksheet.

Related Issue

None

Motivation and Context

Currently, the wasm package lacks the API to obtain the merged cells.

How Has This Been Tested

Add unit unit tests and existing test case passed

Types of changes

Checklist

LogikMeister commented 3 months ago

Thanks for your PR. I intentionally keep the function name same between the Web assembly port and Go language one, to let developer and maintainer be easy to find and maintain all APIs across multi language ports. Can we port GetMergeCells function and implement the interface GetStartAxis and GetEndAxis in TypeScript?

OK, I updated my PR as you suggested. You can check again.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.81%. Comparing base (cf27ddf) to head (2aae962).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================== + Coverage 98.80% 98.81% +0.01% ========================================== Files 1 1 Lines 2594 2627 +33 ========================================== + Hits 2563 2596 +33 Misses 21 21 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/xuri/excelize-wasm/pull/28/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xuri) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xuri/excelize-wasm/pull/28/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xuri) | `98.81% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xuri#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.