Code is not yet working, there is some sort of error that happens and the program exits with error code 2.
the global excelize object is never being set with properties, so it is failing before this
This also shows up in the logs
panic: syscall/js: call of Value.Get on undefined
Also, Reflect.x appear to be invalid usage. Accord to type definitions the first parameter requires a function, but non-function values are being passed in. This should be reviewed and corrected.
Temporary items that will be cleaned up
I have temporarily added in some logging statements that will be removed once the PR is ready for review
Removed terser and added source maps to allow local debugging, this will also be fixed
Delete original index.js - I left this for reference while confirming everything is 100% working
To test the code, run npm install to install new dependencies, then run npm run build to build the JS and GO
Example of what is still failing
PR Details
Migrated library to Typescript
Refactored to more idiomatic modern javascript instead of a mixture of legacy and modern
Added scripts to perform build to package.json
Refactored the node vs browser
Description
This is a 100% refactor that was generally a copy/paste of the initial codebase, but converted to Typescript and cleaned up the codebase a bit to make it easier to read and maintain.
Related Issue
none
Motivation and Context
This is a 100% refactor that was generally a copy/paste of the initial codebase, but converted to Typescript and cleaned up the codebase a bit to make it easier to read and maintain.
The codebase was using a mixture of very legacy javascript and modern javascript.
Prettier has also been added to ensure code formatting remains consistent across contributors.
TODO:
Code is not yet working, there is some sort of error that happens and the program exits with error code 2. the global
excelize
object is never being set with properties, so it is failing before thisThis also shows up in the logs
panic: syscall/js: call of Value.Get on undefined
Also,
Reflect.x
appear to be invalid usage. Accord to type definitions the first parameter requires a function, but non-function values are being passed in. This should be reviewed and corrected.Temporary items that will be cleaned up
index.js
- I left this for reference while confirming everything is 100% workingTo test the code, run
npm install
to install new dependencies, then runnpm run build
to build the JS and GOExample of what is still failing
PR Details
Description
This is a 100% refactor that was generally a copy/paste of the initial codebase, but converted to Typescript and cleaned up the codebase a bit to make it easier to read and maintain.
Related Issue
none
Motivation and Context
This is a 100% refactor that was generally a copy/paste of the initial codebase, but converted to Typescript and cleaned up the codebase a bit to make it easier to read and maintain.
The codebase was using a mixture of very legacy javascript and modern javascript.
Prettier has also been added to ensure code formatting remains consistent across contributors.
How Has This Been Tested
TODO: still testing.
Types of changes
Checklist