Open paustint opened 1 year ago
@xuri - Hopefully I did not overstep any boundaries by raising this PR and I hope you find the changes valuable. I am happy to discuss any of the changes proposed in the PR. Thank you 😸
Thanks for your pull request. This PR contains a lot of code and I need some time to review.
@xuri - No problem, take your time. Let me know if you have any questions or if there is anything that I came up with that you disagree with.
Thanks!
PR Details
index.js
Description
now
is replacedRelated Issue
There is no open issue for this, since it is not really a feature or a bug. Happy to discuss changes here or open an issue if we would like to track an issue along with this PR.
Please let me know. 🙏
Motivation and Context
The
init
function was using a mix of legacy JS and modern JS. This PR cleans up these minor issues. The build process was not documented or automated, this PR includes documentation in the README and automates this using package.json scripts.In addition, a test has been added to ensure that the built code works.
How Has This Been Tested
I added a file to test in NodeJS (just basic usage for now) and I have tested manually in a Typescript web project to ensure that the changes work correctly.
Types of changes
Checklist