xuri / excelize-wasm

A WebAssembly build of the Go Excelize library for reading and writing Microsoft Excel™ (XLAM / XLSM / XLSX / XLTM / XLTX) spreadsheets
https://xuri.me/excelize
BSD 3-Clause "New" or "Revised" License
197 stars 34 forks source link

fix AddTable parameter types #9

Closed spearmootz closed 1 year ago

spearmootz commented 1 year ago

PR Details

Current types are wrong.

Description

if you do wb.AddTable("Sheet1", "A1:B2"); you get invalid arguments

in fact the program expects wb.AddTable("Sheet1", { Range: "A1:B2");

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #9 (6a89f22) into main (dc8bf36) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files           1        1           
  Lines        2695     2695           
=======================================
  Hits         2649     2649           
  Misses         35       35           
  Partials       11       11           
Flag Coverage Δ
unittests 98.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more