xuri / xgen

XSD (XML Schema Definition) parser and Go/C/Java/Rust/TypeScript code generator

BSD 3-Clause "New" or "Revised" License

318 stars 75 forks source link

Remove unnecessary arrays in TS generated code #16

Closed BatmanAoD closed 3 years ago

BatmanAoD commented 3 years ago

Description

A suggested fix for #15. See #17 for an alternative fix.

This is a minimal change intended to address #15. A less minimal version is suggested in #17.

Related Issue

15

How Has This Been Tested

The TS reference base64.xsd.go file has been updated, and the test continues to pass.

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

xuri commented 3 years ago

LGTM, @BatmanAoD thank you very much.