xurizaemon / bolts

A Mattermost bot for CiviCRM
1 stars 3 forks source link

Duplicated StackExchange notifications #26

Open xurizaemon opened 6 years ago

xurizaemon commented 6 years ago

Follows from #14

Hubot double-posts some StackExchange questions, which stands out especially badly during quiet periods in Town Square.

screenshot_20180510-044313

We need to:

xurizaemon/hubot-rss-poller2 is a fork of a module published on NPM - I'm not sure if there's a repo available for contributing back.

(@gobias-nz if you comment with a link to repo I'd love to contribute back fixes like this - looks like the published version on NPM is babel-ified and it would be more useful to contribute to the original code? Would love you to publish that as well!)

joemcl commented 6 years ago

Hey @xurizaemon see this - http://npminstall.org/Install-hubot-rss-poller2-using-npm/ - and this - https://github.com/KanoYugoro/hubot-rss-poller - @KanoYugoro any help with tracking down a repo for hubot-rss-poller2 ?

xurizaemon commented 6 years ago

Actually Joe, Kano's looks like it's what Gobias based their work off, so I will see if we can switch to using that - seems like the original repo is active while hubot-rss-poller2 is not updated since 0.0.5 on npm. Good find :)

joemcl commented 6 years ago

Yeah thanks though was wondering why Kano posted the download and install for poller2 rather than poller...

joemcl commented 6 years ago

Anyway, cool

joemcl commented 6 years ago

Maybe poller2 is just v 2 of poller in Kano's repo....

xurizaemon commented 6 years ago

Current status: I switched to xurizaemon/hubot-rss-poller@build which is my fork of KanuYugoro/hubot-rss-poller. It's not working yet, so the dupe posts are "fixed" (ie bolts has stopped posting anything from RSS). Will revisit "soon" :)

xurizaemon commented 6 years ago

Yeah thanks though was wondering why Kano posted the download and install for poller2 rather than poller...

I don't understand this comment @joemcl ?

joemcl commented 6 years ago

Kano/Anson Wayman is the author of poller, from which poller2 is forked, apparently. The initial link I found here from him (or perhaps someone else) is to install poller2, the fork that someone else (or a different GitHub account name, at least) modified, via npm, rather than his original poller. However, I just discovered that in fact he (or someone else) posted links to install both versions, on the same day, see here, via npm. Doesn't matter, just thought it was curious. He may be the author of both versions, at least he's credited with both at the npm-install site.

xurizaemon commented 6 years ago

Aha, yeah I believe it goes like this -

joemcl commented 6 years ago

OK, now I get it. Not sure what the purpose of that build step using babel is - I see here that babel is a Javascript compiler, I kinda know what a compiler does. Glad you know the workaround :).