xushiwei / pure-lang

Automatically exported from code.google.com/p/pure-lang
1 stars 0 forks source link

$srcdir != $builddir #37

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. "make dist" in trunk, extract the tarball
2. mkdir build && cd build && ../pure-x.y/configure
3. observe etc/pure-mode.el created in ../pure-x.y/etc

What is the expected output? What do you see instead?
configure and Makefile should not modify $srcdir

What version of the product are you using? On what operating system?
r3400 with the changes submitted so far on freebsd-9

Please provide any additional information below.
with the second round of patches in issue36 and this one, the only
untracked files in $srcdir after an out-of-source build are

* lexer.cc
* location.hh
* parser.cc
* parser.hh
* parser.output
* position.hh
* stack.hh

unless i'm mistaken, all these except parser.output are DISTFILES, which
means releases should now play nice in this situation.

Original issue reported on code.google.com by neuhau...@sigpipe.cz on 19 May 2010 at 10:58

Attachments:

GoogleCodeExporter commented 8 years ago
We could get rid of parser.output by leaving out the -v option of bison, but 
it's
convenient to have this file without having to rerun bison manually when there 
are
parsing conflicts after modifying the grammar. So I'd prefer to leave it in. 
Anyway,
this shouldn't be an issue if one uses the distribution tarball, as it includes 
the
generated parser so bison isn't needed when compiling Pure.

The patch concerning pure-mode.el looks ok, but I still need to test it.

Original comment by aggraef@gmail.com on 20 May 2010 at 2:48

GoogleCodeExporter commented 8 years ago
sorry for being unclear: i don't think parser.output is a problem at all.

Original comment by neuhau...@sigpipe.cz on 20 May 2010 at 6:18

GoogleCodeExporter commented 8 years ago
Committed in r3439, thanks!

Original comment by aggraef@gmail.com on 31 May 2010 at 4:41