search

xuwei-k / grpc-scala-sample

translated from grpc java examples with ScalaPB
BSD 3-Clause "New" or "Revised" License
65 stars 25 forks source link

https://scalapb.github.io/grpc.html has a breaking link #10

Closed jyane closed 5 years ago

jyane commented 7 years ago

https://scalapb.github.io/grpc.html links to https://github.com/xuwei-k/grpc-scala-sample/tree/master/grpc-scala/src/main/scala/io/grpc/examples/routeguide but it doesn't exist. I think it is not implemented yet?

So, making an issue to scalapb team or implementing a route guide example is better for scala(pb) beginners.

xuwei-k commented 7 years ago

I have implemented in https://github.com/xuwei-k/grpc-scala-sample/commit/72ea92c7ea01970e1c9950509faef99d2f8809cf#diff-b84192598b743a50efed71ff3b1b92aa

But removed in https://github.com/xuwei-k/grpc-scala-sample/commit/4c4374605088dde8fb8c42772adf00fccd9cd5d5 because these example outdated. We should re-implement these examples.

xuwei-k commented 5 years ago

https://github.com/scalapb/ScalaPB/commit/0800c3c846cec80417ab3e4112650c74618be910