search

xuwei-k / grpc-scala-sample

translated from grpc java examples with ScalaPB
BSD 3-Clause "New" or "Revised" License
65 stars 25 forks source link

ExecutionContext for bindService and for ServerBuilder #21

Open waagnermann opened 10 months ago

waagnermann commented 10 months ago

Hello! In this line you pass executionContext only to GreeterGrpc.bindService but not to ServerBuilder which is possible by calling .executor(..) on ServerBuilder.forPort(HelloWorldServer.port) (source).

You did that for a reason or it was just for the sake of example? What is the best practise here: these two thread pools rather be the same or separate?