search

xuwen-ho / pe

0 stars 0 forks source link

Contradiction with regards to what deletePerson() takes in #16

Open xuwen-ho opened 2 months ago

xuwen-ho commented 2 months ago

image.png

image.png

Difference in sequence diagram, in terms of what deletePerson() method takes in. In one diagram, deletePerson takes in a string "Alex Yeoh" while in another it take in a person object p.

nus-pe-bot commented 2 months ago

Team's Response

Good to fix in future versions.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Thank you for your response. I dont think this is something which is good to fix in future versions, but that it is something that should be fixed now. Because this concerns a very important method, deletePersons, and there is a very different contradiction as to what it takes in, which is quite a notable error in the DG. Hope this helps you.