search

xuwen-ho / pe

0 stars 0 forks source link

Remark commadn should indicate optionality #19

Open xuwen-ho opened 7 months ago

xuwen-ho commented 7 months ago

image.png

image.png

image.png

Remakrk commadn can be run with just remark alex y to remove a remark, without needing a r/ prefix. Hence command in UG should be shown as remark NAME [r/REMARK_DESCRIPTION]

soc-pe-bot commented 7 months ago

Team's Response

Making it optional would mean that the user cannot add their remark which goes against the intended usage of the command.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for your response. I feel that for this command, given you can run just remark alex y and the command works as expected, removing the remark means that the r/ field is optional, and should be labeld as such (with the []). Hope this helps you.