search

xuwen-ho / pe

0 stars 0 forks source link

Does not allow for special characters like '-' or '/' in name #7

Open xuwen-ho opened 5 months ago

xuwen-ho commented 5 months ago

image.png

When adding people, does not allow for special characters like '-' or '/' in name, which is not good considering many people have names containing these, like 's/o' or 'Tan-Smith'

soc-se-bot commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

The restrictions of the NAME parameters do not allow for the / character

The app is unable to support the use of the / character in the name of a contact. This could be troublesome for certain contacts whose names contain the / character (e.g. Indians whose full names contain S/O).

Steps to reproduce: When using either the add or edit commands, use the NAME parameter with a / in it.

Expected behavior: Adds/edits the contact with the name specified.

Actual behavior: An error message describing the input as invalid: Names should only contain alphanumeric characters and spaces, and it should not be blank. The maximum length for a name is 50 characters.

Screenshots: image.png

[original: nus-cs2103-AY2324S2/pe-interim#1634] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

This is addressed in the Planned Enhancements.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]