search

xuxiandi / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

[Enhancement] Adding Wayland typedefs to eglplatform.h #188

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi,

I'm working on adding Wayland (http://wayland.freedesktop.org/) support for 
Chromium. Wayland has its own definitions for EGLNativeDisplayType, 
EGLNativePixmapType, EGLNativeWindowType defined in EGL/eglplatform.h . I 
currently have the system includes #ifdef-ed such that they pick up the latest 
version from mesa 
(http://cgit.freedesktop.org/mesa/mesa/tree/include/EGL/eglplatform.h). 
Naturally, the review comment asked if we can update the angle include to 
contain it. Could we include this change in angle?

Related to chromium code review: http://codereview.chromium.org/7467007/

I've attached a patch with the section I'm interested in.

Thanks,
Daniel Nicoara

Original issue reported on code.google.com by dnico...@chromium.org on 27 Jul 2011 at 1:29

Attachments:

GoogleCodeExporter commented 9 years ago 
We can include them, however it would be best if the Wayland definitions were 
push up into the khronos repository copy of eglplatform.h

Original comment by dan...@transgaming.com on 28 Jul 2011 at 3:17

GoogleCodeExporter commented 9 years ago 
I've asked the Wayland guys about their plans for upstreaming yesterday. I'll 
post back when I have an answer.

For reference, this is the Wayland mailing list post:
http://lists.freedesktop.org/archives/wayland-devel/2011-July/001240.html

Original comment by dnico...@chromium.org on 29 Jul 2011 at 12:54

GoogleCodeExporter commented 9 years ago 
... and this is the response: 
http://lists.freedesktop.org/archives/wayland-devel/2011-July/001241.html 

So for now, there are no plans for pushing the changes to Khronos.

Original comment by dnico...@chromium.org on 29 Jul 2011 at 1:54

GoogleCodeExporter commented 9 years ago 
Ok well I've added them in r709.  (I did refresh the headers from Khronos first 
though).

Hopefully they push the definitions up to Khronos at some point.  That's the 
best way to make sure there are no conflicting type definitions.

Original comment by dan...@transgaming.com on 29 Jul 2011 at 4:34

GoogleCodeExporter commented 9 years ago 
When this done? Released Wayland 1.0!

Original comment by CSRed...@gmail.com on 23 Oct 2012 at 7:45