GoogleCodeExporter
commented
9 years ago Original comment by phajdan.jr@chromium.org on 26 Sep 2011 at 10:43
Closed GoogleCodeExporter closed 9 years ago
GoogleCodeExporter
commented
9 years ago Original comment by phajdan.jr@chromium.org on 26 Sep 2011 at 10:43
GoogleCodeExporter
commented
9 years ago Can you please be more specific what the problem is? All the files clearly
have a license specified in them:
//
// Copyright (c) 2002-2010 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
Original comment by dan...@transgaming.com on 26 Sep 2011 at 11:12
GoogleCodeExporter
commented
9 years ago The files may have license headers, but they're not always recognized by
Debian's licensecheck tool.
For example, compiler/preprocessor/tokens.c has an NVIDIA license header that
is not recognized by licensecheck tool.
Moreover, the above ANGLE license header is not recognized by vanilla
licensecheck, but is recognized by Chromium's modified licensecheck, so those
are sort of fine. Others would need a more detailed look and probably
modifications to the licensecheck tool.
If you'd like to run the Chromium version of the tool from the Chromium
checkout, you can do it like this:
tools/checklicenses/checklicenses.py --ignore-suppressions third_party/angleOriginal comment by phajdan.jr@chromium.org on 26 Sep 2011 at 11:25
GoogleCodeExporter
commented
9 years ago IMHO the tool needs to be improved and I don't see how this is an ANGLE issue.
The include/ headers and compiler/preprocessor files are from external sources
and I've no intention of modifying the licenses on them. The ANGLE license
header is essentially the same as the chromium license.Original comment by dan...@transgaming.com on 30 Sep 2011 at 2:56
GoogleCodeExporter
commented
9 years ago Yeah, some of the files have license headers that are not recognized by the
tools, so it needs to be improved.
Some files are also missing license headers, like
third_party/angle/samples/gles2_book/Hello_Triangle/Hello_Triangle.c and
possibly other samples too.
I've filed Chromium bug
http://code.google.com/p/chromium/issues/detail?id=98698 to deal with this as
advised by Kenneth Russel. Feel free to close this bug.Original comment by phajdan.jr@chromium.org on 30 Sep 2011 at 6:56
GoogleCodeExporter
commented
9 years ago The samples/gles2_book code is from a book.. and is also available online at:
http://code.google.com/p/opengles-book-samples/ It is MIT-licensed over there,
but has identical headers on the code:
//
// Book: OpenGL(R) ES 2.0 Programming Guide
// Authors: Aaftab Munshi, Dan Ginsburg, Dave Shreiner
// ISBN-10: 0321502795
// ISBN-13: 9780321502797
// Publisher: Addison-Wesley Professional
// URLs: http://safari.informit.com/9780321563835
// http://www.opengles-book.com
//
It doesn't explicitly say "copyright" but it seems to be obvious where it comes
from.
Closing as requested.Original comment by dan...@transgaming.com on 30 Sep 2011 at 7:07
GoogleCodeExporter
commented
9 years ago Original comment by phajdan.jr@chromium.org on 16 Oct 2012 at 9:33
Original issue reported on code.google.com by
phajdan.jr@chromium.orgon 26 Sep 2011 at 10:28