[PATCH] VC11 fails to build angle because oppl_allocator::operator= does not exist

[GoogleCodeExporter]

I found out about this when compiling Mozilla using VC11.

See this bug https://bugzilla.mozilla.org/show_bug.cgi?id=694801.

I have a patch which I will submit here.

Original issue reported on code.google.com by ehsan.ak...@gmail.com on 16 Oct 2011 at 12:48

[GoogleCodeExporter]

Ehsan's patch is there: 
https://bug694801.bugzilla.mozilla.org/attachment.cgi?id=567310

Original comment by jacob.be...@gmail.com on 16 Oct 2011 at 12:50

[GoogleCodeExporter]

Original comment by jacob.be...@gmail.com on 16 Oct 2011 at 12:51

[GoogleCodeExporter]

Please review!

Original comment by jacob.be...@gmail.com on 16 Oct 2011 at 12:55

• Changed title: [PATCH] VC11 fails to build angle because oppl_allocator::operator= does not exist

[GoogleCodeExporter]

Here is the patch applied on top of the angle tree.

I had to convert the reference into a pointer in order to be able to assign to 
it inside operator=.

Original comment by ehsan.ak...@gmail.com on 16 Oct 2011 at 4:14

Attachments:

• patch

[GoogleCodeExporter]

Looks fair to me. I'll test it to ensure it causes no regressions...

Original comment by nicolas....@gmail.com on 17 Oct 2011 at 7:14

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by nicolas....@gmail.com on 19 Oct 2011 at 1:15

• Changed state: Started

[GoogleCodeExporter]

Thanks. Committed in r798.

Original comment by dan...@transgaming.com on 19 Oct 2011 at 1:41

[GoogleCodeExporter]

Original comment by dan...@transgaming.com on 19 Oct 2011 at 1:42

• Changed state: Fixed

[GoogleCodeExporter]

Ehsan is a Mozilla employeee (for the CONTRIBUTORS file)

Original comment by jacob.be...@gmail.com on 19 Oct 2011 at 2:44

[GoogleCodeExporter]

Thanks. Fixed in r799.

Original comment by dan...@transgaming.com on 19 Oct 2011 at 3:32