xuxiandi / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Review fix for incorrect TQualifier on gl_FragData #236

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:

BaseTypes.h declares different qualifiers for gl_FragColor and gl_FragData: 
EvqFragColor & EvqFragData. Presumably there is some reason for this. However 
when gl_FragData is used in the fragment shader it is given the EvqFragColor 
qualifier. This patch fixes it so it is given the qualifier EvqFragData.

After the review, please merge the changes to trunk.

Original issue reported on code.google.com by goo...@erewhon0.net on 31 Oct 2011 at 9:23

Attachments:

GoogleCodeExporter commented 9 years ago
Nicolas, Alok, could one of you please review this?

Original comment by kbr@chromium.org on 31 Oct 2011 at 5:55

GoogleCodeExporter commented 9 years ago
Looks correct to me.

Nicholas: Would you mind taking another look and merging the patch?

Original comment by alokp@chromium.org on 31 Oct 2011 at 6:44

GoogleCodeExporter commented 9 years ago
Looks ok. I'll run it through some tests and get it committed.

Original comment by nicolas....@gmail.com on 31 Oct 2011 at 11:09

GoogleCodeExporter commented 9 years ago

Original comment by nicolas....@gmail.com on 2 Nov 2011 at 8:49

GoogleCodeExporter commented 9 years ago
Committed in r879. Thanks!

Original comment by nicolas....@gmail.com on 14 Nov 2011 at 9:21