xuyiqing / fect

fixed effect counterfactual estimators
Other
57 stars 20 forks source link

"Some units have too few pre-treatment observations. Try to remove them." #1

Closed ahearn15 closed 4 years ago

ahearn15 commented 4 years ago

I noticed with the gsynth package, you automatically remove observations that do not reach the min.t0 threshold:

gsynth:

Some treated units has too few pre-treatment periods; they are removed automatically.

fect:

Error in fect.cv(Y = Y, X = X, D = D, I = I, II = II, T.on = T.on, T.off = T.off, : Some units have too few pre-treatment observations. Try to remove them.

Would it be possible for that feature to be added to fect?

xuyiqing commented 4 years ago

Sure. That's doable. Thanks for the suggestion.

On Tue, Jun 2, 2020 at 7:56 PM Adam Hearn notifications@github.com wrote:

I noticed with the gsynth package, you automatically remove observations that do not reach the min.t0 threshold:

gsynth:

Some treated units has too few pre-treatment periods; they are removed automatically.

fect:

Error in fect.cv(Y = Y, X = X, D = D, I = I, II = II, T.on = T.on, T.off = T.off, : Some units have too few pre-treatment observations. Try to remove them.

Would it be possible for that feature to be added to fect?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/xuyiqing/fect/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGBLEKYFCJICRANP3QTRUW3XPANCNFSM4NRIMHIQ .

-- Yiqing Xu

Assistant Professor Department of Political Science Stanford University http://yiqingxu.org/

ahearn15 commented 4 years ago

Great, thank you! Keep up the awesome work.

liqizheng0328 commented 2 years ago

when using your amazing package, I found that it reported the error: Some units have too few pre-treatment observations. Try to remove them. But owing to my date which lacks enough pre-treatment observations, I still want to have a try on scm despite it does not perform well even badly. So what can I do to remove this error or limit.( which may guarantee the credibility of results) I would appreciate some feedback on it. THANK YOU!!!

xuyiqing commented 2 years ago

Hi, You can set min.T0 to a small number.

On Tue, Oct 11, 2022 at 9:41 AM liqizheng0328 @.***> wrote:

when using your amazing package, I found that it reported the error: Some units have too few pre-treatment observations. Try to remove them. But owing to my date which lacks enough pre-treatment observations, I still want to have a try on scm despite it does not perform well even badly. So what can I do to remove this error or limit.( which may guarantee the credibility of results) I would appreciate some feedback on it. THANK YOU!!!

— Reply to this email directly, view it on GitHub https://github.com/xuyiqing/fect/issues/1#issuecomment-1274981971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGCFQEVVGMM4VKST2R3WCWKD5ANCNFSM4NRIMHIQ . You are receiving this because you commented.Message ID: @.***>

-- Yiqing Xu

Assistant Professor Department of Political Science Stanford University https://yiqingxu.org/

liqizheng0328 commented 2 years ago

Hi, You can set min.T0 to a small number. On Tue, Oct 11, 2022 at 9:41 AM liqizheng0328 @.> wrote: when using your amazing package, I found that it reported the error: Some units have too few pre-treatment observations. Try to remove them. But owing to my date which lacks enough pre-treatment observations, I still want to have a try on scm despite it does not perform well even badly. So what can I do to remove this error or limit.( which may guarantee the credibility of results) I would appreciate some feedback on it. THANK YOU!!! — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGCFQEVVGMM4VKST2R3WCWKD5ANCNFSM4NRIMHIQ . You are receiving this because you commented.Message ID: @.> -- Yiqing Xu Assistant Professor Department of Political Science Stanford University https://yiqingxu.org/

Error in gsynth.default(formula = NULL, data = data, Y = Yname, D = Dname, : Some treated units has too few pre-treatment periods. Please set a larger value for min.T0 to remove them. Equal or greater than 6 is recommended.

THANK FOR YOUR REPLY! It seems that this function does not allow me to do that.