xuyiqing / fect

fixed effect counterfactual estimators
Other
53 stars 20 forks source link

How to get repeated results? #11

Closed QLgogo closed 1 year ago

QLgogo commented 3 years ago

Hi, I got some issues in getting repeated results. For example, I run the function "fect()" (method = "mc") on my data twice, without changing any arguments inputted. However, the magnitudes of the results for these two estimations are not exactly the same. I tried to set seed but still cannot get repeated results. Would you mind telling me why this happened and how could I get repeated results? Many thanks in advance!

lzy318 commented 3 years ago

Hi, thanks for that. We have updated the codes, allowing setting random seeds in parallel computing, could you try it again?

QLgogo commented 3 years ago

Thanks for your reply. I have updated the R package and set seed within the function like fect(...seed = 1234). But still I cannot get repeated results. Could you kindly tell me the related codes to use?

lzy318 commented 3 years ago

Can you tell me which part of the estimates is different? The estimated ATT or its standard error/confidence intervals?

QLgogo commented 3 years ago

The estimated ATT is identical but its standard error/confidence intervals/P values are different.

lzy318 commented 3 years ago

OK, thanks a lot. That's a little weird. Could you send your data and codes to zyliu2016@nsd.pku.edu.cn? I will look into it. Another way to get over this problem is to set the option "parallel" to FALSE.