xuyiqing / fect

fixed effect counterfactual estimators
Other
53 stars 20 forks source link

A seeming fatal warming when using methods = "bspline" #6

Closed metascience-lab closed 1 year ago

metascience-lab commented 3 years ago

Hello Prof, I got a warning messages when using methods = "bspline" in "fect" function ,is this warming fatal to the result?
When I use "bspline", this warming comes out, and the result is obviously different from other results from "fe","ife" and "mc" methods. But I could not understand what this warming is:

Warning messages: 1: In if (class(x) != arg.class) stop(ERR.GEN.arg.invalid(arg.name, : the condition has length > 1 and only the first element will be used

This is from the codes as follow:

out.splines <- fect(Y ~ D + X, data = Data, index = c("id","time"), force = "two-way", method = "bspline", CV = TRUE, se = TRUE, nboots = 20, parallel = TRUE,cores = 8)

I would be grateful if you could give me a hand....

Best Regard, Jiajing

xuyiqing commented 3 years ago

The bspline method is not fully developed. And we don't have a clear understanding of its behavior yet.

On Fri, Oct 2, 2020 at 9:27 AM jiajingchan notifications@github.com wrote:

Hello Prof, I got a warning messages when using methods = "bspline" in "fect" function ,is this warming fatal to the result? When I use "bspline", this warming comes out, and the result is obviously different from other results from "fe","ife" and "mc" methods. But I could not understand what this warming is:

Warning messages: 1: In if (class(x) != arg.class) stop(ERR.GEN.arg.invalid(arg.name, : the condition has length > 1 and only the first element will be used

This is from the codes as follow:

out.splines <- fect(Y ~ D + X, data = Data, index = c("id","time"), force = "two-way", method = "bspline", CV = TRUE, se = TRUE, nboots = 20, parallel = TRUE,cores = 8)

I would be grateful if you could give me a hand....

Best Regard, Jiajing

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/xuyiqing/fect/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGAJ6O7LXATXZTSVYT3SIX5Q5ANCNFSM4SB4TSAA .

-- Yiqing Xu

Assistant Professor Department of Political Science Stanford University http://yiqingxu.org/

metascience-lab commented 3 years ago

ok, thanks!