search

xuyiqing / fect_stata

Stata package for Fixed Effect Counterfactual Estimators
MIT License
23 stars 11 forks source link

Proportion option #4

Closed hcbrianlee closed 8 months ago

hcbrianlee commented 8 months ago

Thank you for developing the package.

I've noticed that when generating the figures, sometimes it doesn't display every period in my dataset. I initially thought this might be related to the graph parameters. Upon reviewing the ado file, I discovered that adjusting the option "proportion" lower (defaulted at 0.3) makes these periods reappear. Would it be possible for you to include an explanation of the "proportion" option in the help file?

Thanks!

xuyiqing commented 8 months ago

Hi It's in the help file of plot.fect(). You can try:

help(plot.fect)

and will see the explanation.

hcbrianlee commented 8 months ago

Thanks Yiqing! I was using STATA, but I could also check the help file in R. Thanks again for developing the method and package.

xuyiqing commented 8 months ago

I see. Sorry. I'll double check with the stata help file!

On Fri, Feb 2, 2024 at 6:04 PM hcbrianlee @.***> wrote:

Thanks Yiqing! I was using STATA, but I could also check the help file in R. Thanks again for developing the method and package.

— Reply to this email directly, view it on GitHub https://github.com/xuyiqing/fect_stata/issues/4#issuecomment-1925019129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGB5FLA2BU5DMC6EKZTYRWLKFAVCNFSM6AAAAABCXFJUOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGAYTSMJSHE . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Yiqing Xu

Assistant Professor Department of Political Science Stanford University https://yiqingxu.org/

hcbrianlee commented 8 months ago

Thank you!

On Feb 2, 2024 at 9:15 PM, <Yiqing Xu @.***)> wrote:

I see. Sorry. I'll double check with the stata help file!

On Fri, Feb 2, 2024 at 6:04 PM hcbrianlee @.***> wrote:

Thanks Yiqing! I was using STATA, but I could also check the help file in R. Thanks again for developing the method and package.

— Reply to this email directly, view it on GitHub https://github.com/xuyiqing/fect_stata/issues/4#issuecomment-1925019129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGB5FLA2BU5DMC6EKZTYRWLKFAVCNFSM6AAAAABCXFJUOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGAYTSMJSHE . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Yiqing Xu

Assistant Professor Department of Political Science Stanford University https://yiqingxu.org/

— Reply to this email directly, view it on GitHub (https://github.com/xuyiqing/fect_stata/issues/4#issuecomment-1925022512), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AWBB2RU7FU2WWARCKCE52D3YRWMS5AVCNFSM6AAAAABCXFJUOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGAZDENJRGI). You are receiving this because you authored the thread.Message ID: @.***>