xuyiqing / gsynth

Generalized Synthetic Control Method
Other
131 stars 40 forks source link

Are all treatment times shifted towards {T_0} when doing Matrix Completion? #51

Open feliuserra opened 3 years ago

feliuserra commented 3 years ago

Hi, I was wondering whether all observations are shifted such that $T_0$ (or the first time period with treatment) are the same before computing the Matrix Completion? Or this shift is only done when computing ATTs?

After having read the paper a few times, I assume that that is the case for computing the interactive fixed effects with factor loadings, but I am not sure about the Matrix Completion. Could you please help clarify this? Thank you very much in advance!

xuyiqing commented 3 years ago

Thank you. We'll look into it!

On Wed, Nov 18, 2020 at 4:14 AM Feliu Serra Burriel < notifications@github.com> wrote:

Hi, I was wondering whether all observations are shifted such that $T_0$ (or the first time period with treatment) are the same before computing the Matrix Completion? Or this shift is only done when computing ATTs?

After having read the paper a few times, I assume that that is the case for computing the interactive fixed effects with factor loadings, but I am not sure about the Matrix Completion. Could you please help clarify this? Thank you very much in advance!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/xuyiqing/gsynth/issues/51, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGGOQUUP5WSUPWHWQ2LSQO3DDANCNFSM4TZ4OZVA .

-- Yiqing Xu

Assistant Professor Department of Political Science Stanford University http://yiqingxu.org/

feliuserra commented 3 years ago

Thanks! Let me know if I can help somehow.