search

xuyiqing / gsynth

Generalized Synthetic Control Method
Other
131 stars 40 forks source link

Error in gsynth.default if entire ids and time periods are dropped #67

Open ruettenauer opened 2 years ago

ruettenauer commented 2 years ago

Hi Yiqing,

Many thanks for the great package first of all!!

I have recently encountered an error in gsynth.default if entire ids and periods need to be dropped. The error results from different dimensions in obs.missing and I.old if periods are dropped. The error message is: Error in obs.missing[, rm.id] <- 4 : incorrect number of subscripts on matrix, but the problem originates from the line above obs.missing[which(I.old == 0)] <- 0 as the two objects have different numbers of rows.

I've edited some basic lines in gsynth.default which circumvent the problem. I'll create a pull request with that in a second, maybe it helps to fix the problem.

Thanks and best wishes Tobi

xuyiqing commented 2 years ago

Hi Tobi,

Have you installed the most up-to-date github version? If yes, could you send a sample data with code (and panelview plot) to our email addresses?

Best, Yiqing

On Tue, Sep 14, 2021 at 4:03 AM Tobias Rüttenauer @.***> wrote:

Hi Yiqing,

Many thanks for the great package first of all!!

I have recently encountered an error in gsynth.default if entire ids and periods need to be dropped. The error results from different dimensions in obs.missing and I.old if periods are dropped. The error message is: Error in obs.missing[, rm.id] <- 4 : incorrect number of subscripts on matrix, but the problem originates from the line above obs.missing[which(I.old == 0)] <- 0 as the two objects have different numbers of rows.

I've edited some basic lines in gsynth.default which circumvent the problem. I'll create a pull request with that in a second, maybe it helps to fix the problem.

Thanks and best wishes Tobi

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/xuyiqing/gsynth/issues/67, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGBDVHLJW72GW6IQOJ3UB4TYVANCNFSM5D74E2QA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Yiqing Xu

Assistant Professor Department of Political Science Stanford University

https://yiqingxu.org/