search

xuyiqing / gsynth

Generalized Synthetic Control Method
Other
131 stars 40 forks source link

is `weight` option supported when se=T? #73

Open jtorcasso opened 2 years ago

jtorcasso commented 2 years ago

When I run

out <- gsynth(y ~ d, data = fit.data, index = c("zip","t"), 
    estimator='ife', force = "two-way", r = 6, CV=F, se = T, weight=NULL)

everything runs smoothly, but when I include a weight, and run

out <- gsynth(y ~ d, data = fit.data, index = c("zip","t"), 
    estimator='ife', force = "two-way", r = 6, CV=F, se = T, weight='pop')

I get the error Bootstrap inference fails. Please check the data.. FYI, I can get the second snippet to run if I set se=F.

jtorcasso commented 2 years ago

FYI, I've played around with synthetic data, and haven't been able to replicate the error yet with a MWE. But if anyone has an intuition for what's going on before then, I'd be happy to hear.

xuyiqing commented 2 years ago

Thanks! We'll look into this.

Best, Yiqing

On Thu, Dec 16, 2021 at 4:32 PM jtorcasso @.***> wrote:

FYI, I've played around with synthetic data, and haven't been able to replicate the error yet with a MWE. But if anyone has an intuition for what's going on before then, I'd be happy to hear.

— Reply to this email directly, view it on GitHub https://github.com/xuyiqing/gsynth/issues/73#issuecomment-996306914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGHHJ4SZ5CBF47UGQKTURKAKVANCNFSM5KHR4IZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Yiqing Xu

Assistant Professor Department of Political Science Stanford University https://yiqingxu.org/