search

xuyuxuan2570 / GLC_Replication.jl

0 stars 0 forks source link

hard coded file path #4

Open floswald opened 5 months ago

floswald commented 5 months ago

how should this work on somebody else's computer?


# true results
data_result = matread("C:\\Users\\peter\\.julia\\dev\\glc_replication\\replication_package\\data_appendix\\matlab\\matlab\\data_result.mat")

Like. Do you think evyerbody has a user called peter on their system? what's more, I don't think that can run on your own computer. :-/

xuyuxuan2570 commented 5 months ago

Dear Florian,

I have updated the code. The reason why there is a "peter" there is because as I told you and the screenshot shows, we (Peter and me) write the code together, and I send my part to him. So the whole project is cloned from his computer. I changed it on my VS code but forget to save it... that's my problem and I am so sorry for that. I have tried my update again I thought it works on my computer now. Sorry for all the inconvenience. Thank you so much and have a nice day!

Best regards, Yuxuan

On Thu, May 23, 2024 at 3:42 PM Florian Oswald @.***> wrote:

how should this work on somebody else's computer?

true results

data_result = matread("C:\Users\peter\.julia\dev\glc_replication\replication_package\data_appendix\matlab\matlab\data_result.mat")

Like. Do you think evyerbody has a user called peter on their system? what's more, I don't think that can run on your own computer. :-/

— Reply to this email directly, view it on GitHub https://github.com/xuyuxuan2570/GLC_Replication.jl/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/A54W5FXJCSUWK7EJJVTR2R3ZDWMUTAVCNFSM6AAAAABIFCKDHGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTEMJZGE4DIMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

floswald commented 5 months ago

sorry in your code you now have this:

data_result = matread("/Users/xuyuxuan/Desktop/po/computer econ/project/112395-V1/matlab/data_result.mat")

without instructions of how to change that how am I supposed to run this? /Users/xuyuxuan does not exist on my computer!!

also the path seems wrong to start with. in your repo, there is this folder instead. refer to it if you want the code to use it.

https://github.com/xuyuxuan2570/GLC_Replication.jl/tree/main/growing_like_china_replication_project/data_appendix/matlab/matlab

xuyuxuan2570 commented 5 months ago

Oh...I am so sorry for the issue. I misunderstand your comment. I have changed it to "$path/growing_like_china_replication_project/data_appendix/matlab/matlab/data_result.mat", which after cloning the project, you can just change the "$path" to where you download the project into your computer. So sorry for that!

xuyuxuan2570 commented 5 months ago

Dear Florian, I have changed it again. As you said, I use url ='https://github.com/xuyuxuan2570/GLC_Replication.jl/tree/main/growing_like_china_replication_project/data_appendix/matlab/matlab/data_result.mat' data_result = matread(url) instead, I hope it works now!