search

xuzhengyi1995 / Manga_downloader

A Manga download framework using selenium.
620 stars 57 forks source link

add cut_image = dynamic #106

Closed Letsplaybar closed 1 year ago

Letsplaybar commented 1 year ago

The change I made ensures that instead of entering a fixed value for cut_image, you can say that the image should be dynamically cropped. For this it takes the first image (should be the cover) and looks at where a white border exists and returns this as a bbox so that the crop method knows where to remove the white border and takes over the values for the rest of the band. This way, if you dump several series, the programme can easily ensure that you no longer have a white border in any manga.

to get the above you only have to set cut_image = 'dynamic'.

xuzhengyi1995 commented 1 year ago

Thanks!

Letsplaybar commented 1 year ago

https://github.com/xuzhengyi1995/Manga_downloader/commit/e301e20c969e7febc16ed42ac83687bf382b2a70 Why was the commit not taken over? you still have to adjust the init method so that it can handle the new value.

xuzhengyi1995 commented 1 year ago

e301e20 Why was the commit not taken over? you still have to adjust the init method so that it can handle the new value.

Will cherry pick this commit, thanks!