search

xuzhengyi1995 / Manga_downloader

A Manga download framework using selenium.
607 stars 57 forks source link

Can you please explain it? #141

Open rasbayri opened 1 year ago

rasbayri commented 1 year ago

I have done this millions of times and I still don't get it plz I'm a dummy

If this not work and show 'Uncaught TypeError: Cannot read properties of undefined (reading 'menu') at :1:54', it means BW has updated the js, you can try to find it in the console, just try NFBR.a6G.Initializer..menu is not undefined and the is the new object name; Or you can just file a bug.

rasbayri commented 1 year ago

What about adding support to ebookjapan.yahoo.co.jp? Would you want to make it?

Lucky2307 commented 1 year ago

For the error, it seems to mean that the JS version has changed. Here's what you need to do to find the correct one:

  1. Go to the reader page
  2. Open the console (F12), and type NFBR.a6G.Initializer
  3. Find the child that has the 'menu' child in it. It is currently 'L7v' image
  4. Change this line in websiteactions/bookwalker*_actions.py (whichever you use) https://github.com/xuzhengyi1995/Manga_downloader/blob/55c0013896f61e95e680f16c96c5aa3829137904/website_actions/bookwalker_jp_actions.py#L41 'NFBR.a6G.Initializer.Z4p.menu.options.a6l.moveToPage(%d)' % page) to 'NFBR.a6G.Initializer.L7v.menu.options.a6l.moveToPage(%d)' % page)

Now it should work fine

I'm actually trying out a way to automatically detect the correct key, so hopefully in the future it won't run into this issue.