feat: clean up included/excluded, changed GraphExecutor

[github-actions[bot]]

(🤖 AI Generated)

Summary

This pull request removes the deprecated fabric_patterns_included and fabric_patterns_excluded options from the application configuration and command-line arguments. It also refactors the GraphExecutor class to accept the graph during initialization rather than during execution.

Files Changed

• code/app.py: Modified to remove deprecated options and refactor GraphExecutor.

Code Changes

1. Removed Deprecated Options

• AppConfig Class

  Removed the optional attributes fabric_patterns_included and fabric_patterns_excluded:

  class AppConfig:
    fabric_model: str
    fabric_temperature: float
    agent_type: Literal["single_command", "react"]
    # Removed deprecated options
    # fabric_patterns_included: Optional[str] = None
    # fabric_patterns_excluded: Optional[str] = None

• Command-Line Arguments

  Removed the corresponding command-line arguments from the parse_arguments function:

  def parse_arguments() -> AppConfig:
    # ...
    # Removed deprecated arguments
    # fabric_group.add_argument(
    #     "--fabric-patterns-included",
    #     type=str,
    #     help="Comma separated list of fabric patterns to include in agent",
    # )
    # fabric_group.add_argument(
    #     "--fabric-patterns-excluded",
    #     type=str,
    #     help="Comma separated list of fabric patterns to exclude in agent",
    # )

• FabricTools Instantiation

  Updated the initialization of FabricTools to remove the now-unused parameters:

  def main() -> None:
    # ...
    fabric_tools = FabricTools(
        fabric_llm.llm, fabric_llm.use_system_message, fabric_llm.number_of_tools
    )
    # ...

2. Refactored GraphExecutor

• GraphExecutor Initialization

  Modified the GraphExecutor class to accept the graph during initialization:

  class GraphExecutor:
    """Handles graph execution and output generation"""
  
    def __init__(self, config: AppConfig, graph):
        self.config = config
        self.graph = graph
        self._setup_output_encoding()

• Execution Method

  Updated the execute method to use the instance's graph instead of accepting it as a parameter:

  def execute(self, input_str: str) -> None:
    try:
        messages_state = self._invoke_graph(self.graph, input_str)
        # ...

• Main Function Adjustment

  Adjusted the instantiation and use of GraphExecutor in main():

  def main() -> None:
    # ...
    executor = GraphExecutor(config, graph)
    executor.execute(input_str)
    # ...

Reason for Changes

• Removal of Deprecated Options: The fabric_patterns_included and fabric_patterns_excluded options are no longer supported by the FabricTools. Removing these options cleans up the codebase and prevents potential confusion or misuse of deprecated features.

• Refactoring GraphExecutor: Passing the graph during initialization promotes better encapsulation of the GraphExecutor class. It associates the graph with the executor’s state, simplifying the execution flow and enhancing code clarity.

Impact of Changes

• Functionality Simplification: Eliminating deprecated options reduces complexity and the potential for bugs related to unused parameters.

• Improved Code Maintenance: Cleaning up deprecated code aids in long-term maintenance and readability.

• Enhanced GraphExecutor Design: The refactoring may improve testability and future scalability of the GraphExecutor class.

Test Plan

• Unit Tests: Run existing unit tests to ensure no regressions have been introduced.

• Application Testing:

  • Verify that the application starts correctly without the deprecated command-line options.
  • Test primary functionalities to ensure they operate as expected with the updated GraphExecutor.

Additional Notes

• Documentation: Update the application’s documentation and help messages to reflect the removal of the deprecated options.

• User Communication: Inform users about the removal of --fabric-patterns-included and --fabric-patterns-excluded options and provide guidance or alternatives if necessary.

• Code Clean-Up: Ensure that any other references to the deprecated options are also removed from the codebase.