search

xvrh / lottie-flutter

Render After Effects animations natively on Flutter. This package is a pure Dart implementation of a Lottie player.
https://pub.dev/packages/lottie
MIT License
1.16k stars 196 forks source link

use FilterQuality.low to default when draw image layer to fix some image render sawtooth #230

Closed JerryFans closed 2 years ago

JerryFans commented 2 years ago

FilterQuality.none is the fastest filtering method but also the lowest quality, so use FilterQuality.low to default when draw image layer to fix some image render sawtooth by default.

xvrh commented 2 years ago

@ZanderZhan Any opinion on this? (since you were the one adding filterQuality)

@JerryFans Is FilterQuality.none not the default in Flutter for the Image widget? Can you expand on why it is better for lottie to default to a different setting?

JerryFans commented 2 years ago

Snip20220825_81

@xvrh Also you can see Image widget source code. when it paint image , this FilterQuality default option is FilterQuality.low. In my flutter project use Lottie, the image render sawtooth by default (FilterQuality.none). use FilterQuality.low to default set, can Better quality than [none]. (enum FilterQuality annotation )

JerryFans commented 2 years ago

@ZanderZhan Any opinion on this? (since you were the one adding filterQuality)

@JerryFans Is FilterQuality.none not the default in Flutter for the Image widget? Can you expand on why it is better for lottie to default to a different setting?

@xvrh Also you can see Image widget source code. when it paint image , this FilterQuality default option is FilterQuality.low.

xvrh commented 2 years ago

Thanks for the contribution. I released 1.4.2 with this change

ZanderZhan commented 2 years ago

@ZanderZhan Any opinion on this? (since you were the one adding filterQuality)

@JerryFans Is FilterQuality.none not the default in Flutter for the Image widget? Can you expand on why it is better for lottie to default to a different setting?

@xvrh FilterQuality: none is more friendly to previous version. change to FilterQuality.low actually a break change and may bring an unpredictable problem to others who use older version.

xvrh commented 2 years ago

@ZanderZhan so you think this change is not good?

ZanderZhan commented 2 years ago

@ZanderZhan so you think this change is not good?

@xvrh Yes, or maybe you should marked it an important or break change in the changelog , I think that's fine too.