xvvvyz
commented
6 years ago Hey. Sorry for my late reply, and thanks for the PR!
On 1: I tried this fix, and I'm getting console errors when hovering suggestions now. Also, tabbing through the suggestions was buggy.
On 2: I couldn't reproduce this error on Chrome 64.0.3282.186, what browser are you using?
First of all, awesome work! This is a clean looking start page and I can tell you spent a lot of time on it.
I am adding this push request to fix some minor bugs I came across while using tilde.
The first bug I noticed was that if your mouse was hovering over the area that the suggestions appeared while you typed, the page would automatically register those mouseover events. I know that you could move the mouse, but why waste all that precious time? :) I fixed this by adding a mousemove event to the document and only adding the mouseover event to the buttons when the mouse is touched.
The second bug was just a small error that was thrown when scrolling through suggestions with your arrow keys. It was thrown when you reached the last suggestion and the highlight disappeared. I fixed this by adding a check to make sure there was another suggestion in your array and if not it would go back to the first suggestion.
I have checked and I believe everything works, but there was some javascript quirks that made me have do some weird things (such as making sure functions weren't binded in event listeners), so please let me know if you find any issues.
Thanks!