search

xwikisas / application-activedirectory

Provides the UI to set up LDAP for Active Directory
GNU Lesser General Public License v2.1
1 stars 2 forks source link

The number of imported groups by the "LDAP Group Import" scheduler job is limited to 1000 #84

Closed mouhb closed 10 months ago

mouhb commented 10 months ago

We configured the "LDAP User Import" Application to import all groups from an LDAP directory that contains many groups (more than 1000). The "LDAP Group Import" executed correctly but the number of imported groups was limited to 1000.

Note that the pagination of group members have been already implemented, see https://jira.xwiki.org/browse/LDAP-59, so, a new search method (searchPaginated(...)) that allows paginating the LDAP search results have been added to the class XWikiLDAPConnection , see https://github.com/xwiki-contrib/ldap/blob/ff0f33bc0213f7901798562b99e6d250b8494132/ldap-authenticator/src/main/java/org/xwiki/contrib/ldap/XWikiLDAPConnection.java#L574

So, to fix the issue the DefaultLDAPGroupImportManager#getImportableGroups(...) method should be improved to use the paginated search method here : https://github.com/xwikisas/application-ldapuserimport/blob/27505f386df0ce28131aacae604e373409e1be8c/application-ldapuserimport-api/src/main/java/com/xwiki/ldapuserimport/internal/DefaultLDAPGroupImportManager.java#L93

mouhb commented 10 months ago

The issue have been fixed on LDAP User Import Application and the dependency to LDAP User Import Application has been upgraded to 1.5.6.