search

xwikisas / application-diagram

Create various types of diagrams using draw.io
GNU Lesser General Public License v2.1
0 stars 8 forks source link

Errors in browsers console when editing a diagram #136

Open ane-gabriela opened 4 years ago

ane-gabriela commented 4 years ago

Steps to reproduce:

  1. Open browser console in Chrome/Firefox/IE/Edge
  2. Edit any diagram

Expected results: The diagram can be edited with no errors in the browser console.

Actual results: There are errors in every browser.

Environment: Windows 10, XWiki 11.10.4 with MySQL 5.7, IE 11, Chrome 81, Firefox 75, Edge 18

IE11 IE11EditingDiagram

Chrome 81 ChromeEditing

Firefox 75 FirefoxEditing

Edge 18 EdgeEditing

mflorea commented 3 years ago

Actual results: The diagram can be edited but there are errors in every browser.

The end users don't care about the logged JavaScript messages as long as the diagram editor works. End users don't open the JavaScript console.

mflorea commented 3 years ago

The only remaining error logged on Firefox after closing #192 is the "XML Parsing Error: unclosed token". This is not logged in Chrome so it appears to be specific to Firefox. The issue seems to be related to a SVG image loaded using data URI but it's hard to spot which one and we don't control those SVGs anyway (they come from draw.io library).

Note that I see "XML Parsing Error: unclosed token" logged also when accessing draw.io online so this seems to confirm that this is a draw.io issue related to some SVG image they use and which upsets Firefox (but not Chrome).