search

xwikisas / application-diagram

Create various types of diagrams using draw.io
GNU Lesser General Public License v2.1
0 stars 8 forks source link

Can't save diagrams with text inside certain shapes #144

Closed oanalavinia closed 4 years ago

oanalavinia commented 4 years ago

Steps to reproduce:

Create a new diagram Add a Diamond / Triangle/ Actor / Round (not squared) shape with text inside Click on Save & View / Save

Expected results: The diagram is saved.

Actual results: The Save & View / Save button becomes disabled but the page remains blocked and nothing happens, the page is not saved.

issue_diamondText

oanalavinia commented 4 years ago

Investigation: The issue is caused by: https://github.com/xwikisas/application-diagram/blob/master/application-diagram-ui/src/main/resources/Diagram/DiagramEditSheet.xml#L865 'rect' is available only for squared shapes, and for other shapes a 'path' svg element is actually the parent of the text node. So there should be added a way to calculate the maximal width of the text element (used for wrapping) in this cases

oanalavinia commented 4 years ago

Reopening since the fix is not complete.

Here https://github.com/xwikisas/application-diagram/blob/master/application-diagram-ui/src/main/resources/Diagram/DiagramEditSheet.xml#L876 it is not taking into consideration only the last rect parent, but any that could be found in the diagram, leading to the blocked save if you do not have any rect in the diagram, or to a wrong width, which does not correspond to the current element.