License is not recognized while upgrading diagram

xwikisas / application-diagram

Create various types of diagrams using draw.io

GNU Lesser General Public License v2.1

0 stars 7 forks source link

License is not recognized while upgrading diagram #196

Closed CamiAndrei closed 1 month ago

CamiAndrei commented 3 years ago

While upgrading Diagram from version 1.16.0 to 1.16.1 the license is not recognized. (XWiki 12.10.6) Screenshot from 2021-05-25 19-13-01

The licenses of other application are not recognized either.

This issue can be a temporary blocker if there is a XWiki Pro license, because of the pop-up.

The license is recognized again after the installation completed.

mflorea commented 3 years ago

@CamiAndrei I don't reproduce. This is what I did:

I installed Diagram Application (Pro) 1.16 on XWiki 13.4
I asked for a trial license
I upgraded Diagram Application (Pro) to 1.16.1

The license was fine afterwards. I really don't see how upgrading Diagram Application (Pro) (and only that as the screenshot with the upgrade plan shows) can break the license.

Note that your first screenshot shows that you have installed Diagram 1.16 not 1.16.1. Is this screenshot taken after the upgrade? Would be good to provide the exact steps to reproduce the problem. Thanks.

CamiAndrei commented 3 years ago

Hi! @mflorea The issue is present only for the time the application is upgrading. Yes after the upgrade is completed the license is recognized again.The screenshots are taken during the upgrade of the extension, not before, not after. Steps to reproduce:

I installed Diagram Application (Pro) 1.16 on XWiki 13.4
I asked for a trial license
I upgraded Diagram Application (Pro) to 1.16.1, but not completely. At this step, the license was not recognized anymore: \ See: But after the upgrade was completed the license was recognized again.

I hope now it's more clear.

It may not be a big issue, but it may cause confusion among users that use the wiki while the extension is upgrading.

mflorea commented 3 years ago

@CamiAndrei I still cannot reproduce. I followed your steps but the Diagram license was fine after the upgrade plan was computed, before executing the upgrade plan. I really don't see how the upgrade plan can break the license. There must be something else that triggered the issue.