xwikisas / application-diagram

Create various types of diagrams using draw.io
GNU Lesser General Public License v2.1
0 stars 7 forks source link

Cannot modify diagram title in diagram editor #219 #221

Closed trrenty closed 2 years ago

mflorea commented 2 years ago

Please upload a screenshot. Thanks.

trrenty commented 2 years ago

@mflorea image

mflorea commented 2 years ago

I'm not sure the icon before the "Title" label brings any value, on the contrary, it could be misleading / confusing. Plus it's not consistent (we don't use that icon elsewhere in XWiki before the title label). I think you should drop it. Otherwise it looks OK. Ideally, I would have liked the page title (heading) to be replaced by an "invisible" text input, similar to the in-place edit, in order to avoid the duplication (e.g. "DiagramTest" is displayed twice). But your solution works fine.