search

xwikisas / application-diagram

Create various types of diagrams using draw.io
GNU Lesser General Public License v2.1
0 stars 8 forks source link

If unregistered users have restricted access, importing images will break the cached diagrams #233

Closed oanalavinia closed 1 year ago

oanalavinia commented 1 year ago

Prerequisites: Have the following rights set: image

Steps to reproduce:

  1. Create a new diagram or edit an existing one
  2. Insert an image using the + button -> Image... -> Open / Drag and drop
  3. Save the diagram
  4. Observe the attachments

Expected result: the image was added as attachment and the resulted diagram.svg and diagram.png are correct Actual result: the image was added as attachment, but it's missing from diagram.svg and diagram.png

If I add a svg image: image If I add a png image: image

Editing the diagram will not solve the problem

Tested with XWiki 13.10.6 and Diagram Application 1.17.2

petrenkonikita112263 commented 1 year ago

After checking rights as mentioned, I can't reproduce issue. By inserting image (PNG, JPEG) format and saving diagram - image is present in attachment section alongside with original diagram files (SVG & PNG).

It was checked with latest version v1.19.4 of app on XWiki v13.10

image

Note image won't be saved in attachment section if user paste image via URL. I tried to insert this image via URL and it's present in diagram. Example of XAR.

oanalavinia commented 1 year ago

Indeed, the issue is reproducing on version 1.17.2, but not after upgrading to 1.19.4. Most probably it has been fixed by a drawio upgrade, so I'll close it as cannot reproduce