search

xwikisas / application-diagram

Create various types of diagrams using draw.io
GNU Lesser General Public License v2.1
0 stars 8 forks source link

Image path migration is not working if the drawio webjar version contains a - #248

Closed oanalavinia closed 1 year ago

oanalavinia commented 1 year ago

Steps to reproduce:

  1. Install diagram version with a version between [1.17, 1.18], since these versions depend on xwiki-contrib/drawio 14.4.3-2 and add a license
  2. Create a diagram Diagram.Test1 and edit it
  3. Use the Left menu -> Search Shapes to search for a complex shape. E.g. search and select the internet cloud shape (only certain shapes will make this issue to reproduce, since only some of them are stored using a link)
  4. Save and observe that the shape is displayed
  5. Upgrade diagram to a version >1.18, since this will add the xwiki-contrib/drawio 20.5.0 webjar
  6. Go to Diagram.Test1 and observe the added shape

Expected result: The shape is displayed

Actual result: The shape is not displayed

Investigation: The reason is that the migration that fixes this problem does not covers the case where the drawio version contains a - as in 14.4.3-2 The workaround for now is to re-add the shapes