search

xwikisas / application-diagram

Create various types of diagrams using draw.io
GNU Lesser General Public License v2.1
0 stars 5 forks source link

Saving imported draw.io file fails #267

Closed avision-it closed 3 weeks ago

avision-it commented 1 month ago

Some imported draw.io files fail to save in a diagram page. I think it's related to embedded images or pdfs. Here's the screenshot if you click Save & View:

image

The page is empty afterwards and there are no attachments. The upload fails without further errors in the console or tomcat logs.

I've tested it on a fresh install and our production system.

I've attached a test file that fails to save. Can you please look into this problem?

Test_12224.zip

XWiki 15.10.8, Diagram Application Pro 1.20.4

petrenkonikita112263 commented 1 month ago

Indeed, I can also reproduce by attempting the import not only your file, but any drawio file from sample page. However, if I use import from URL and put the full URL like this https://raw.githubusercontent.com/jgraph/drawio-diagrams/dev/examples/uml-activity-example.drawio after saving the diagram is present.

https://github.com/xwikisas/application-diagram/assets/56109799/393f32ec-0ad2-40ac-964b-b19d0ef0cb1b

avision-it commented 1 month ago

Hmm, i get one step further with Import from URL. But i still can't save the diagram. This error message occurs when saving:

image

But I'm not logged off and it's not an authorization problem. I'm clueless what could be the problem...

oanalavinia commented 1 month ago

There are 2 issues here. The first issue is that for the specific file from the issue description, the upload size limit is reached and so the save is blocked. I will check, but most probably I would have to add a diagram configuration to let admins modify this limit when needed (I created https://github.com/xwikisas/application-diagram/issues/268 for this)

The second one is that indeed, you cannot save the diagram after importing any draw.io file. This is related to the implementation of the multiple pages feature in https://github.com/xwikisas/application-diagram/issues/250 , so it was introduced in version 1.22.3 Checking to fix the issue as part of this ticket. Until then, a workaround would be to downgrade Diagram Application to an older version, e.g. 1.22.2 (the upload limit would still be present)