search

xwikisas / application-diagram

Create various types of diagrams using draw.io
GNU Lesser General Public License v2.1
0 stars 4 forks source link

Diagram links not showing until page is refreshed, after editing a page with a diagram macro #269

Open ane-gabriela opened 1 month ago

ane-gabriela commented 1 month ago

Steps to reproduce:

  1. Create a diagram "Diagram-1"

  2. Add some shapes

  3. In one or 2 of the shapes add some text

  4. Select a word and link it to another page in the wiki

  5. Select another word and link it to an external URL
    DiagramWithLinks

  6. Create a new simple page

  7. Edit it and click on Insert > Other Macros

  8. Search for Diagram Macro

  9. In the "Reference" Field type the name of the existing diagram page (e.g. Diagram.Diagram-1.WebHome)

  10. Uncheck "Cached"

  11. Click Submit

  12. Click on Save & View

Expected results: The diagram appears with the selected links.

Actual results: The diagram appears with no links, the user needs to refresh the page 1or 2 times to see the links.

After Save & View ResultDiagram1

After Refresh AfterRefreshDiagram

Environment: Windows 11, Chrome 125, Cloud XWiki 15.10.8, Diagram Application (Pro) 1.20.4

oanalavinia commented 2 weeks ago

This happens only when using inline editing mode, and it's not only for the first time you add a diagram macro (that links to a diagram with links), but every time you inline edit a page with such diagrams. Basically, the view you had in edit mode, with a diagram image instead of the actual diagram, is preserved until you refresh the page. From what I understand, this is the expected behavior, since inline editing tries to transition from edit to view smoothly. @mflorea can you confirm this is the expected behavior, or should I look more into it?