Can't export a diagram as PDF

xwikisas / application-diagram

Create various types of diagrams using draw.io

GNU Lesser General Public License v2.1

0 stars 8 forks source link

Can't export a diagram as PDF #270

Closed ane-gabriela closed 2 months ago

ane-gabriela commented 6 months ago

Preconditions: Have a diagram page created with added shapes.

Edit the diagram page
Click on File > Export as > PDF...
Click on Export
Choose a name for the diagram
Click on Download

Expected results: The diagram is exported as PDF.

Actual results: The diagram isn't exported

PDFExport

Environment: Windows 11, Chrome 125. Cloud XWiki 15.10.8, Diagram Application (Pro) 1.20.4

mflorea commented 6 months ago

Note that here are two ways you can export a diagram to PDF:

From the diagram editor: the diagram is sent to a remote service to perform the conversion to PDF. This remote service is configurable, but by default diagrams.net is used which we don't control. Such a remote service can obviously be down, have access limits, misbehave or change its behavior in a way that is not backwards compatible with our version of draw.io
from the page view mode: the diagram is exported to PDF by us, which is normally more reliable

So we need to check:

if the failure is temporary or related to some service limits
if the failure is caused by some specific diagram content
if the failure is caused by a change in the service URL or expected parameters
if the failure is caused by a change in the service implementation that is not backwards compatible with our version of draw.io

oanalavinia commented 5 months ago

I am still investigating on this issue, couldn't find the root cause yet.

It's important to mention that the structure of the request altered a little on newer drawio versions. For example there are more parameters for this method and these could be required for the request to work. So a drawio upgrade seems necessary anyway. On another note, I did tried locally to apply these changes and the export still doesn't work, but I might be missing something (there are a lot of changes to consider). Unfortunately, the request response is not giving that much information. I would suggest to go on with the drawio upgrade and that come back at this issue

Until this is fixed, it's important to know that File -> Print could be used as a workaround, and it's actually safer since you don't send your data to an external server. Check https://www.drawio.com/blog/export-pdf#secure-pdf-generation

ilieandriuta commented 5 months ago

Issue reproduced too on XWiki 16.4.0 using Diagram Application (Pro) 1.20.5.

snazare commented 3 months ago

proposal: when clicking on File - Export As - PDF use the File -> Print service. To check again post upgrade to drawio

ane-gabriela commented 2 months ago

@snazare Tested on XWiki 15.10.10 with version 1.21-rc-1, extension id com.xwiki.diagram:application-diagram (drawio24.5.5) - got the same result as above, the diagram is not exported

Steps to reproduce:

While editing the Diagram click on File > Export as > PDF... >Export
Select a name for the exported diagram
Select Device / Download / Open in New Window
Click on the Save or OK button depending on the selection made previously

Actual results: No matter the selection made the result is the same - no diagram appears in the export

DownloadResult

snazare commented 2 months ago

to be handled in #288