search

xwikisas / application-diagram

Create various types of diagrams using draw.io
GNU Lesser General Public License v2.1
0 stars 8 forks source link

Some name strategies might break the diagram macro #314

Closed Farcasut closed 7 hours ago

Farcasut commented 8 hours ago

Some name strategies may lack a null check to validate the name parameter, which causes the Diagram macro to break when an invalid name is encountered.

Steps to Reproduce

  1. Create a new page.
  2. Add this macro call: {{diagram /}}
  3. Change the default naming strategy in XWiki to the "Preformatted Names" strategy.

Expected Behavior The create button / diagram is shown as expected.

Actual Behavior The diagram macro breaks

Farcasut commented 7 hours ago

The issue can be reproduced in versions 1.20.8 and 1.20.9 and was fixed in version 1.21

Farcasut commented 7 hours ago

This was fixed as part of #302