search

xwikisas / application-filemanager

XWiki application to manage a hierarchy of folders and files
GNU Lesser General Public License v2.1
0 stars 4 forks source link

An attachment with comma symbol in filename can't be opened #66

Closed petrenkonikita112263 closed 11 months ago

petrenkonikita112263 commented 1 year ago

Environment: XWiki v. 14.10.3 App v. 2.5.5 Browser MS Edge latest

Step to reproduce:

  1. Install File Manager (Pro)
  2. Go to the License tab and obtain a Trial license
  3. From the Applications menu, open File Manager
  4. Download any PDF sample file from here
  5. Rename the downloaded PDF file so it'll have , in its filename (for instance, Free_Test_Data,500KB_PDF.pdf)
  6. Click on the File Manager icon (from a window in step 3) - New File - and select the file from step 5
  7. Try to open a newly uploaded PDF file

Actual Result You can't open it, due to the existence of , symbol in the filename. The File Manager app will recognize one file as 2 files (Free_Test_Data & 500KB_PDF.pdf) image

Expected Result The uploaded PDF file with the name Free_Test_Data,500KB_PDF.pdf opened without any issue (as it has or doesn't have , in the filename) image

Current workaround Remove from the name , or any special symbols that can cause this issue.

petrenkonikita112263 commented 11 months ago

I think we can close this issue because it doesn't related to File Manager (Pro) directly. The issue is caused by PDF Viewer (Pro) which can't proceed with any pdf attachment with , in filename and it is a dependency for File Manager (Pro). Furthermore, the content of this issue was reported on dedicated repository Macro PDF Viewer (Pro) - The PDF file isn't shown when it contains a comma in the title

oanalavinia commented 11 months ago

The PDFViewer issue was fixed as part of the 2.5.2 release and the dependency was upgraded in https://github.com/xwikisas/application-filemanager/commit/91d5250b300c4bb91db3a313cd91d2438d2e8d17