xwikisas / application-googleapps

Google Apps Integration
0 stars 4 forks source link

Embedding cannot always work #36

Open polx opened 4 years ago

polx commented 4 years ago

It appears that the embedding function (which relies on the Drive API's embedLink property) cannot work in all cases.

People who have view access on the wiki page may be unauthorized to access the google drive.

There appears to be no way to be warned about this. In principle this would be ok if the user would be understanding that this problem can be solved by changing permissions at Google but thus far I only see a blank page.

AndreeaChi commented 1 year ago

While testing Google Apps Integration 2.5.2., I noticed that this indeed happens if a user, with only View right given at wiki level, goes to a page that has the Drive macro added and if they try to embed a file, they would be shown that access is denied for them.

image

They would also see a message like Unauthorized Error 401 if they go to a page where there is an embedded document already.

image
ane-gabriela commented 1 month ago

Issue reproducing on Cloud XWiki 15.10.8 with Google Apps Integration (Pro) 2.6.1 and Chrome 125

EmbedIssue

I think it is also related to https://github.com/xwikisas/application-googleapps/issues/75