search

xwikisas / application-googleapps

Google Apps Integration
0 stars 4 forks source link

XWiki "Login with Google" doesn't work #60

Closed AlexandraSiriciuc closed 3 years ago

AlexandraSiriciuc commented 3 years ago

Steps to reproduce:

Expected result: The app is configured properly and the Google user can login.

Actual result: Able to see "Login with Google" in the login page. When clicked "Login with Google" received the following error : xwiki13 3 screenshot

polx commented 3 years ago

Is there a domain-name restriction in the GoogleApps admin?

AlexandraSiriciuc commented 3 years ago

No, there is no domain-name restriction, please see the screenshot: googleapps-admin

polx commented 3 years ago

Maybe a whitespace inside the field? The code indeed only checks if the field is completely empty. Any non-printable character would still count.

AlexandraSiriciuc commented 3 years ago

I checked to make sure there was no whitespace, setup saved and after restarting the instance, the same error.

polx commented 3 years ago

Is the site accessible for me to get into? What you describe is exactly contrary to what I read in the code and what I tested. E.g. what does /xwiki/bin/edit/GoogleApps/GoogleAppsConfig?editor=object&force=1 show? paul

ppantiru commented 3 years ago

This was tested on local 13.3 instances and the result was the same for me and Ilie as well so I don't think it's about misspellings anymore. We followed the instructions from the store page, so either the instructions are not up to date anymore or there has been a regression of sorts. However I have not tested for earlier versions.

AlexandraSiriciuc commented 3 years ago

Please find below a screenshot from the mentioned page: Objectscreenshot

Thanks, please let me know if there is anything I can do

polx commented 3 years ago

Thank you @AlexandraSiriciuc . This is solved in 2.4.10.