search

xwikisas / application-googleapps

Google Apps Integration
0 stars 4 forks source link

Unchecking the 'activate' checkbox from the administration does not remove the "login with google" button from the login screen #63

Open lucaa opened 2 years ago

lucaa commented 2 years ago

This is about this option in the administration:

image

From the documentation I understand that this checkbox is needed for the google authentication to work, and I imply that if it's unchecked, it should disable the google authentication.

The login screen still displays the 'login with google' and 'login with xwiki' options even when the checkbox is unchecked.

ilieandriuta commented 2 years ago

I've also tested and reproduced the issue on XWiki 14.4, using Google Apps Integration (Pro) 2.5.2 (Chrome 102/ Oracle 19c/ Tomcat 9.0.63/ Java 17).

mflorea commented 2 years ago

The hint for the "Activate" setting is not super clear but it does indicate that it is about "editing office attachments using the Google Apps editors" and about "upload a Google Apps file to any wiki page". I checked the code and this setting is taken into account only in https://github.com/xwikisas/application-googleapps/blob/stable-2.x/src/main/resources/GoogleApps/JSExtension.xml#L124 which is the JavaScript code that enhances the Attachments doc extra tab at the bottom of the page.

So @lucaa if you want to keep the issue as is then we only need to improve the hint and the application documentation. If you need a setting to disable the Google login then this becomes a new feature request which needs to be discussed (one could argue that if you don't want the Google login then you can uninstall the application). Moreover, being able to disable an installed extension could be seen as a generic need, so it wouldn't make sense that each application writes their own code to implement this.